chore: cleanup dependencies #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
chore/cleanup-deps
branch
2 times, most recently
from
cb83d5a
to
0299337
Compare
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
chore/cleanup-deps
branch
from
0299337
to
402caf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all patches and instead uses subxt versioning, the parachain dependencies have been feature-gated to not pull in additional Substrate dependencies. In the future we should rely on the metadata where possible and only substitute basic types (or those we control such as
CurrencyId) - for example I removed the manualRichDispatchErrordecoding. Also made some superfluous cleanups to make the runtime crate look nicer.Note that
Cargo.lockactually got bigger because we're pulling in the weak dependency (sp-runtime) frominterbtc-primitives(due to rust-lang/cargo#10801) but AFAIK these packages aren't compiled.